Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@malvidin
Copy link
Contributor

@malvidin malvidin commented Apr 14, 2023

Describe the change
Using the default container names inside a Docker Compose deployment simplifies communication with backend replicas.

No changes were made to code, only configuration files (YAML and .env)

Describe testing procedures

  • Uncommented the replica lines for backend, and built the containers.
docker-compose -f build/docker-compose.yaml build
docker-compose -f build/docker-compose.yaml up -d
go build github.com/target/strelka/src/go/cmd/strelka-oneshot
  • Submitted samples and got expected results.
./strelka-oneshot -f samples/Win32.Emotet.zip -l - | jq

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

malvidin and others added 3 commits April 14, 2023 18:19
Set host references using internal container names
Add optional Docker backend replicas
Set host references using internal container names
Add optional Docker backend replicas
@phutelmyer
Copy link
Contributor

Thank you @malvidin! This seems more appropriate than what we had before. :)
I'll test this out and merge it in.

@phutelmyer phutelmyer added the enhancement New feature or request label Apr 17, 2023
@phutelmyer phutelmyer merged commit 3b40901 into target:master Apr 18, 2023
@phutelmyer
Copy link
Contributor

Built and ran with no cache successfully. This looks good. Approving and merging. Thank @malvidin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants