Decode base64 in HTML href and div content #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # 'ScanBase64': | ||
| # - positive: | ||
| # flavors: | ||
| # - 'base64_file' |
Contributor
Author
There was a problem hiding this comment.
base64_file isn't referenced anywhere besides the configs. In the scanner I use the flavor of just base64 since it's not exactly a file. However I don't have a strong opinion and can change the flavor to base64_file if that's preferred.
Contributor
There was a problem hiding this comment.
I'll review this scanner, appreciate the review here
Contributor
|
Tested + works. No issues here. |
phutelmyer
approved these changes
Apr 18, 2023
Contributor
|
@cameron-dunn-sublime Seems theres a conflict in the backend.yml now. This may have been an issue with work I approved earlier today. Can you pull and review? |
Contributor
Author
|
@phutelmyer should be set now! The conflict was just against a change that removed a space in commented out lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Supports extracting base 64 content from HTML
divtags, as well as adds an "external flavor" ofbase64to base64 extracted content.Originally implemented in sublime-security#34. There are some differences because that was implemented before
self.emit_filewas available.Describe testing procedures
I ran an example file via Oneshot and recorded the output. I ran this with
ScanBase64enabled (which isn't necessary for the core abilities, but makes the result a bit clearer).Sample output
Sample Input
Sample output
You can see
test string one - linkandtest string two - divin the output which shows the base64 content was extracted by ScanHTML and extracted by ScanBase64.Checklist