Add VRM1SceneLoader support #31
Conversation
Bone-Ash
commented
Jun 13, 2025
- New VRM1SceneLoader class for VRM1 format
- loadThumbnail
- image
- bufferView
- buffer
- Extended UIImage init for VRM1 image loading
- New VRM1SceneLoader class for VRM1 format
- loadThumbnail
- image
- bufferView
- buffer
- Extended UIImage init for VRM1 image loading
There was a problem hiding this comment.
Summary of Changes
Hello @Bone-Ash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request adds initial support for loading VRM1 models by introducing a dedicated VRM1SceneLoader class. This new loader provides the foundational capabilities to parse VRM1 files and access core data like images and buffers, paving the way for full VRM1 model rendering in SceneKit.
Highlights
- New VRM1 Loader: Introduced a new
VRM1SceneLoaderclass specifically designed to load VRM1 format models into a SceneKit context. This class handles parsing the VRM1 structure and accessing underlying GLTF data. - Image Loading Support: Added functionality within
VRM1SceneLoaderand an extension toUIImageto correctly load images referenced in the VRM1/GLTF data, supporting both URI references and images embedded in GLTF buffer views. - Data Access Methods: Implemented methods within
VRM1SceneLoaderto access raw buffer and buffer view data from the GLTF structure, which is essential for loading various model components like images. - Thumbnail Loading: Included a specific method (
loadThumbnail) inVRM1SceneLoaderto easily retrieve the thumbnail image defined in the VRM1 metadata.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces the VRM1SceneLoader class for loading VRM1 format data, extends UIImage initialization for VRM1 image loading, and updates the String extension for error conformance. The primary feedback focuses on adding bounds checks to array accesses within the VRM1SceneLoader to prevent potential runtime crashes.
|
Thank you for the pull request! |