fix: set_build_settings adjustment to avoid overflowing configuration blocks (fix #14462) #14652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14462
I propose minimal adjustments to
set_build_settingsto fix the issue described in #14462. It feels a bit hacky to me, but I do not own a macos machine and so I had to iterate on a GitHub runner until I got it to work. This is why I didn't want to change it up too much...It could also be used as a base to build a better implementation, but I believe it is a net improvement from what was there at the start and so could probably be released in the next patch release to unblock people relying on manual signing (and who might, like me, have limited access to Apple hardware).