fix(macOS): correct value for work_area.position.y #14655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Package Changes Through 9dcc0cfThere are 4 changes which include tauri-utils with patch, tauri-build with patch, tauri-cli with patch, tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the value of
work_area.position.yis returning 0. On a screen with a menubar, this should be something like 38. This makes it difficult to position windows at the top of the screen correctly.This calculation was originally set in #13309, however the math seems incorrect.
This calculation was removed in #13401, which set the value back to 0.
You can set the window position to 0, and it seems the system will (usually, not always) move the window below the menu bar. However, it would be better if I can just directly move the window to where it should be (y=38).
The PR attempts to correct the calculation for
position.y. It takes into account the bottom-up coordinate system used byvisible_frame. It should work correctly regardless of the menu bar size and presence.