Less statics #14668
Open
Less statics #14668
+641
−650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auri_dir) = tauri_dir tauri_dir.is_some() must be true, otherwise the entire block is not run, so the frontend_dir check is irrelevant
Contributor
Package Changes Through 2e0caf5There are 4 changes which include tauri-utils with patch, tauri-build with patch, tauri-cli with patch, tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
Author
|
Any chance to run CI automatically on my PRs? Would make iteration much faster, I often miss things built only on other platforms. |
Member
That decision will probably take longer to discuss than your pr will be open x) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on refactoring the globals in tauri-cli. I think this is beneficial as-is, but it is not quite finished.
This still is missing a full transition towards lazy initialized
tauri_dirandfrontend_dirwhile guaranteeing not to break anything, as discussed in this comment.Read commit-by-commit.