Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tayloraswift
Copy link
Owner

/gemini review

@gemini-code-assist
Copy link

Summary of Changes

Hello @tayloraswift, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the WhitespaceFormatter by implementing a new feature for folding labeled expressions and arguments. The primary goal is to improve code readability and reduce vertical space by intelligently collapsing arguments onto fewer lines, specifically by removing newlines between colons and their corresponding values, and between expressions and trailing commas. This is achieved through the introduction of specialized syntax visitors and rewriters, along with a new configurable option to manage this formatting style.

Highlights

  • New Argument Folding Feature: Introduced the ability to fold labeled expressions and arguments, removing newlines between colons and values, and between expressions and trailing commas for more compact code.
  • New Syntax Processors: Added ArgumentCalculator (a SyntaxVisitor) to identify optimal positions for folding, and TokenFolder (a SyntaxRewriter) to apply the actual whitespace adjustments.
  • Enhanced VerticalRewriter: The VerticalRewriter protocol's align function was made more flexible by allowing an optional separator, enabling precise control over whitespace insertion during folding.
  • New Configuration Option: A foldArguments boolean option was added to WhitespaceOptions, allowing users to enable or disable this new formatting behavior, with a default value of true.
  • Comprehensive Testing: New unit tests in ArgumentFoldingTests.swift were added to ensure the correct functionality of both labeled and unlabeled argument folding scenarios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new formatting capability to fold labeled expressions, which is a great addition. The implementation is well-structured, following the existing visitor/rewriter pattern in the formatter. I've added a few minor suggestions to improve code style and consistency, such as making a class final and removing some redundant or unconventional syntax. The new tests are also comprehensive and cover the new functionality well.

@@ -0,0 +1,21 @@
import SwiftSyntax

class TokenFolder: SyntaxRewriter {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other rewriter/visitor classes in this project (e.g., ModifierFolder, ArgumentCalculator) and as a general Swift best practice, it's good to mark this class as final since it's not designed to be subclassed. This can also offer a minor performance improvement to the compiler.

Suggested change
class TokenFolder: SyntaxRewriter {
final class TokenFolder: SyntaxRewriter {

@tayloraswift tayloraswift merged commit cf7508e into master Nov 15, 2025
2 checks passed
@tayloraswift tayloraswift deleted the labeled-expr-folding branch November 15, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants