-
-
Notifications
You must be signed in to change notification settings - Fork 0
Labeled expr folding #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tayloraswift, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new formatting capability to fold labeled expressions, which is a great addition. The implementation is well-structured, following the existing visitor/rewriter pattern in the formatter. I've added a few minor suggestions to improve code style and consistency, such as making a class final and removing some redundant or unconventional syntax. The new tests are also comprehensive and cover the new functionality well.
| @@ -0,0 +1,21 @@ | |||
| import SwiftSyntax | |||
|
|
|||
| class TokenFolder: SyntaxRewriter { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other rewriter/visitor classes in this project (e.g., ModifierFolder, ArgumentCalculator) and as a general Swift best practice, it's good to mark this class as final since it's not designed to be subclassed. This can also offer a minor performance improvement to the compiler.
| class TokenFolder: SyntaxRewriter { | |
| final class TokenFolder: SyntaxRewriter { |
/gemini review