don’t wrap atomic syntax #8
Conversation
Summary of ChangesHello @tayloraswift, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the whitespace formatter by introducing a specific rule to avoid line wrapping for empty array expressions, which previously could lead to awkward formatting. Concurrently, a new test case has been added to comprehensively verify that atomic syntax elements maintain their intended inline structure when formatted, ensuring consistency and correctness in the output. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prevents wrapping of empty array literals ([]), which is a good improvement for code formatting consistency. The change is correct and is accompanied by a new test case. My review includes a suggestion to also handle empty dictionary literals expressed as [] for complete consistency, which appears to be an oversight in the current implementation.
/gemini review