Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Lost job #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Lost job #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07e5149
testcase
Nov 12, 2021
67d9214
comment upd
Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,9 @@ func (w *Worker) Start() {
}
}

// XXX: make this configurable ?
const flushIntv = time.Second

func (w *Worker) start(ctx context.Context, h handler) {
defer w.wg.Done()

Expand Down Expand Up @@ -300,7 +303,6 @@ func (w *Worker) start(ctx context.Context, h handler) {
}
}()

const flushIntv = time.Second
flushTicker := time.NewTicker(flushIntv)
defer flushTicker.Stop()

Expand Down
80 changes: 80 additions & 0 deletions worker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,86 @@ func TestWorkerRunJobMultiQueue(t *testing.T) {
require.EqualValues(t, 0, count)
}

func TestLostJob(t *testing.T) {
/*
Within the same queue:

1. Job with id "X" is enqueued
2. Job with id "X" is dequeued by worker №1
3. Job with id "X" is enqueued
4. Handler of worker №1 returns without error
5. Worker №1 flushes ACK
6. Job enqueued at step 3 is lost
*/
client := redistest.NewClient()
defer client.Close()
require.NoError(t, redistest.Reset(client))

w := NewWorker(&WorkerOptions{
Namespace: "{ns1}",
Queue: NewRedisQueue(client),
})
successTaken := make(chan struct{})
successDone := make(chan struct{})
err := w.Register("success",
func(*Job, *DequeueOptions) error {
close(successTaken)
<-successDone
return nil
},
&JobOptions{
MaxExecutionTime: time.Minute,
IdleWait: time.Millisecond * 60,
NumGoroutines: 1,
},
)
require.NoError(t, err)

type message struct {
Text string
}
job := NewJob()
job.ID = "X"
err = job.MarshalPayload(message{Text: "hello"})
require.NoError(t, err)

err = w.opt.Queue.Enqueue(job, &EnqueueOptions{
Namespace: "{ns1}",
QueueID: "success",
})
require.NoError(t, err)

const queueKey = "{ns1}:queue:success"

count, err := client.ZCard(context.Background(), queueKey).Result()
require.NoError(t, err)
require.EqualValues(t, 1, count)

w.Start()
<-successTaken

err = w.opt.Queue.Enqueue(job, &EnqueueOptions{
Namespace: "{ns1}",
QueueID: "success",
})
require.NoError(t, err)

close(successDone)

time.Sleep(flushIntv * 2) // Should get flushed after this

z, err := client.ZRangeByScoreWithScores(
context.Background(),
queueKey,
&redis.ZRangeBy{
Min: "-inf",
Max: "+inf",
}).Result()
require.NoError(t, err)
require.Len(t, z, 1)
w.Stop()
}

func TestWorkerRunJob(t *testing.T) {
client := redistest.NewClient()
defer client.Close()
Expand Down