Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Greatly improve static path performance #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2018
Merged

Greatly improve static path performance #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efeed77
improve static route lookup performance
stakach Nov 2, 2018
71941a1
add check for wildcard routes
stakach Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/router/handler/handler.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@ module Router

def initialize
@tree = Radix::Tree(Action).new
@static_routes = {} of String => Action
end

def search_route(context : HTTP::Server::Context) : RouteContext?
method = context.request.method
route = @tree.find("/" + method.upcase + context.request.path)
search_path = "/" + context.request.method + context.request.path
action = @static_routes[search_path]?
return {action: action, params: {} of String => String} if action

route = @tree.find(search_path)
return {action: route.payload, params: route.params} if route.found?

nil
Expand All @@ -24,7 +27,16 @@ module Router
end

def add_route(key : String, action : Action)
@tree.add(key, action)
if key.includes?(':') || key.includes?('*')
@tree.add(key, action)
else
@static_routes[key] = action
if key.ends_with? '/'
@static_routes[key[0..-2]] = action
else
@static_routes[key + "/"] = action
end
end
end
end
end