Merged
Conversation
shogo82148
commented
Jun 15, 2021
| - name: Test | ||
| run: make cover | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GHTOOLS_GITHUB_TOKEN }} |
Contributor
Author
There was a problem hiding this comment.
Please set secrets for GitHub Actions.
https://docs.github.com/en/actions/reference/encrypted-secrets
https://docs.github.com/en/rest/reference/actions#secrets
It needs collaborator access to do it.
shogo82148
commented
Jun 15, 2021
Comment on lines
+23
to
+29
| if token == "" { | ||
| if os.Getenv("CI") != "" { | ||
| t.Skipf("The %s environment value is not configured. skip it.", EnvGitHubToken) | ||
| } else { | ||
| t.Fatalf("The %s environment value is not configured. To skip it, set CI=true", EnvGitHubToken) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We need this because secrets are not passed to the runner when a workflow is triggered from a forked repository.
See https://docs.github.com/en/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow
Songmu
added a commit
that referenced
this pull request
Jun 15, 2021
## [v0.14.0](v0.13.0...v0.14.0) (2021-06-15) * udpate deps [#134](#134) ([Songmu](https://github.com/Songmu)) * fix lint warnings [#133](#133) ([shogo82148](https://github.com/shogo82148)) * Migrate to GitHub Actions [#132](#132) ([shogo82148](https://github.com/shogo82148)) * Allow use of ENV Varaibles to run tests which upload to github [#130](#130) ([JehandadK](https://github.com/JehandadK))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #131
travis-ci.com is an awesome service, however contributors need some credits if they want to run tests on forked repositories.
So, I propose to migrate GitHub Actions.