feat: add queue options for attachments crop and mail sender processors #2047
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds queue options configuration for job retention in the mail sender merge and attachments crop processors. The changes implement automatic cleanup of completed and failed jobs to prevent unbounded queue growth.
Key changes:
- Added
NestWorkerOptionsconfiguration to both processors withremoveOnCompleteandremoveOnFailsettings - Removed unused imports (
Loggerfrom mail-sender processor anddayjs)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/nestjs-backend/src/features/mail-sender/open-api/mail-sender.merge.processor.ts | Added queue options with 1000 job retention limit and cleaned up unused imports |
| apps/nestjs-backend/src/features/attachments/attachments-crop.processor.ts | Added queue options with 2000 job retention limit and made queueOptions exportable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/nestjs-backend/src/features/attachments/attachments-crop.processor.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/nestjs-backend/src/features/mail-sender/open-api/mail-sender.merge.processor.ts
Show resolved
Hide resolved
apps/nestjs-backend/src/features/attachments/attachments-crop.processor.ts
Show resolved
Hide resolved
🧹 Preview Environment Cleanup
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.