Fix incorrect maximum number of chunks per packet#3280
Open
Robyt3 wants to merge 1 commit intoteeworlds:masterfrom
Open
Fix incorrect maximum number of chunks per packet#3280Robyt3 wants to merge 1 commit intoteeworlds:masterfrom
Robyt3 wants to merge 1 commit intoteeworlds:masterfrom
Conversation
The maximum number of chunks per packet is limited to 255 due to the value being packed into 1 byte in the chunk header. The incorrect limit caused full packets to be packed with the number of chunks value being 0 due to the value 256 overflowing, which would result in receivers not unpacking any chunks due to the number being 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum number of chunks per packet is limited to 255 due to the value being packed into 1 byte in the chunk header. The incorrect limit caused full packets to be packed with the number of chunks value being 0 due to the value 256 overflowing, which would result in receivers not unpacking any chunks due to the number being 0.
See ddnet/ddnet#10504