feat: API 6.0 #1614
Merged
feat: API 6.0 #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muthu Kumar <[email protected]>
Signed-off-by: Muthu Kumar <[email protected]>
Reason: method could be called in `web_app_data` Signed-off-by: Muthu Kumar <[email protected]>
Signed-off-by: Muthu Kumar <[email protected]>
Co-authored-by: Eddy Otsutsuki <@hypernova7> Signed-off-by: Muthu Kumar <[email protected]>
Reasoning: web_app_data is only available for KeyboardButton Web Apps, which doesn't have web app query identifier and cannot use answerWebAppQuery Use bot.tg.answerWebAppQuery instead Signed-off-by: Muthu Kumar <[email protected]>
KnorpelSenf
approved these changes
Apr 28, 2022
Collaborator
KnorpelSenf
left a comment
There was a problem hiding this comment.
LGTM, just a few nits here and there (optional to fix), plus a few questions about things I'm wondering about. Nothing that would be blocking.
Signed-off-by: Muthu Kumar <[email protected]>
Signed-off-by: Muthu Kumar <[email protected]>
This was referenced Apr 29, 2022
Signed-off-by: Muthu Kumar <[email protected]>
Signed-off-by: Muthu Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markup.button.webApphelpertelegraf/typesto be imported directly without relying on a separate dependency ontypegram. The export interface is not stable. It may change at a later dateTry it out before it lands using
npm install telegraf@canary