Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@antlai-temporal
Copy link
Contributor

What was changed

This PR updates next-server to catch-up with main changes and then updates server (and api)
to the latest (v1.28.0-130.0 and v1.46.0 respectively)

Sushisource and others added 7 commits February 27, 2025 10:08
)

<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR! 
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->

<!--- For ALL Contributors 👇 -->

## What was changed
<!-- Describe what has changed in this PR -->
Add extended info to the DescribeWorkflow output.
## Why?
<!-- Tell your future self why have you made these changes -->
Customer request.
…-with-start` commands (temporalio#762)

added `temporal workflow start-update-with-start` and `temporal workflow
execute-update-with-start` commands

`temporal workflow start-update-with-start` usage: 
```
    temporal workflow start-update-with-start \
      --update-name YourUpdate \
      --update-input '{"update-key": "update-value"}' \
      --update-wait-for-stage accepted \
      --workflow-id YourWorkflowId \
      --type YourWorkflowType \
      --task-queue YourTaskQueue \
      --id-conflict-policy Fail \
      --input '{"wf-key": "wf-value"}'
  ```


`temporal workflow execute-update-with-start` usage:
  ```
    temporal workflow execute-update-with-start \
      --update-name YourUpdate \
      --update-input '{"update-key": "update-value"}' \
      --workflow-id YourWorkflowId \
      --type YourWorkflowType \
      --task-queue YourTaskQueue \
      --id-conflict-policy Fail \
      --input '{"wf-key": "wf-value"}'
  ```

1. Closes temporalio#664

2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them -->

3. Any docs updates needed?
Yes
## What was changed
quote attribute type in error message 

## Why?
To make whitespace more obvious

---------

Co-authored-by: Rodrigo Zhou <[email protected]>
<!--- Note to EXTERNAL Contributors -->
<!-- Thanks for opening a PR! 
If it is a significant code change, please **make sure there is an open
issue** for this.
We work best with you when we have accepted the idea first before you
code. -->

<!--- For ALL Contributors 👇 -->

## What was changed
<!-- Describe what has changed in this PR -->
Check if extended info is not nil.

## Why?
<!-- Tell your future self why have you made these changes -->
temporalio#771
Code assumes that some extended info exists in proto. Which is not true
for older server versions..
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks

@antlai-temporal antlai-temporal merged commit 4504b96 into temporalio:next-server Mar 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants