Added Docker instructions to README #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 11, 2025
74b22b2 to
cd07cfc
Compare
dandavison
reviewed
Jul 14, 2025
dandavison
reviewed
Jul 14, 2025
|
|
||
| Note that for dev server to be accessible from host system, it needs to listen on external IP and the ports need to be forwarded: | ||
|
|
||
| docker run --rm -p 7233:7233 -p 8233:8233 temporalio/temporal:latest server start-dev --ip 0.0.0.0 |
There was a problem hiding this comment.
Can we make --ip 0.0.0.0 not be required for start-dev when it's running inside docker?
There was a problem hiding this comment.
Right now the default IP is hardcoded to 127.0.0.1, we'd have to introduce a new env var or a config file in the command's code to allow changing the default within the container. We can create an issue for that.
cd07cfc to
b922303
Compare
Co-authored-by: Dan Davison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information how to use official CLI Docker image to README.