Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

Conversation

@feedmeapples
Copy link
Contributor

What was changed:

Made the search attribute keys show up in the UI
image

Why?

The keys were getting lost and replaced by array index

Checklist

  1. Closes issue:

  2. How was this tested:

  1. Any docs updates needed?

@feedmeapples feedmeapples requested review from robholland and swyxio May 7, 2021 01:16
Copy link
Contributor

@robholland robholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Copy link
Contributor

@swyxio swyxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Copy link
Contributor

@swyxio swyxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@feedmeapples feedmeapples merged commit ab0ae4b into master May 7, 2021
@feedmeapples feedmeapples deleted the search-attributes branch May 7, 2021 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants