Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

Conversation

@feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented May 12, 2021

What was changed

Sorting of workflows in ALL view is changed to the following:

  1. Initially fetches 10 items of both open and closed workflows. Orders them by Start Time
    before it was not sorting the first 20 items and instead always showed Open workflows first
  2. Proceeds fetching in chunks of 10, either Open or Closed each depending on the start time
    image

Why?

Addresses an issue that ALL view always showed Open workflows first, even if there are newer closed workflows

Checklist

  1. Closes issue:

  2. How was this tested:

  • Create test data using openNClosed fixture from samples-go
  • Verify that ordering of the first 20 items works in desc order by startTime
  • The subsequent items should be sorted in chunks of 10 (either open or closed)
  1. Any docs updates needed?

No

@feedmeapples feedmeapples requested a review from swyxio May 12, 2021 22:25
@feedmeapples feedmeapples enabled auto-merge (squash) May 12, 2021 22:57
@feedmeapples feedmeapples merged commit fcd2874 into master May 13, 2021
Copy link
Contributor

@swyxio swyxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trusty old lodash!

@feedmeapples feedmeapples deleted the sort-workflows branch May 13, 2021 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants