Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

Improve stack trace readability #336

Merged
feedmeapples merged 1 commit into from
May 25, 2021
Merged

Improve stack trace readability #336

feedmeapples merged 1 commit into from
May 25, 2021

Conversation

@feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented May 25, 2021 •
edited
Loading

What was changed

Makes stack trace easier to read
before:
image

after:
image

Why?

Improves readability

Checklist

  1. Closes issue:

  2. How was this tested:

Test Data variations:

  • HelloQuery.java java sample
  • OpenNClosed go fixture with open workflows
  • OpenNClosed go fixture with closed workflows (no stack trace)
  • Not having workflow running
  1. Any docs updates needed?

No

@feedmeapples feedmeapples requested a review from swyxio May 25, 2021 08:25
@feedmeapples feedmeapples changed the title Improve stack trace redability Improve stack trace readability May 25, 2021
@feedmeapples feedmeapples enabled auto-merge (squash) May 25, 2021 08:35
swyxio
swyxio approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@swyxio swyxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful!

@feedmeapples feedmeapples merged commit 44073a7 into master May 25, 2021
@feedmeapples feedmeapples deleted the stack-trace branch May 25, 2021 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@swyxio swyxio swyxio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@feedmeapples @swyxio