This repository was archived by the owner on May 26, 2023. It is now read-only.
Add timestamp to console log #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68f289f to
0abbaab
Compare
stevekinney
reviewed
Jul 19, 2021
server/use-console-timestamp.js
Outdated
| return '[' + new Date().toISOString() + '] '; | ||
| }; | ||
|
|
||
| const useConsoleTimestamp = () => { |
There was a problem hiding this comment.
Are you concerned that this is also likely going to override console.log (and its friends) for our dependencies as well since we're money patching a global?
There was a problem hiding this comment.
I hate saying this out loud, but I almost wonder if we should use our own logging function rather than monkey-patching a Node global. We basically console.log about 7 times in the code base, so it's not a heavy lift.
Contributor
Author
There was a problem hiding this comment.
yes that's actually much safer. Will do
stevekinney
reviewed
Jul 19, 2021
0abbaab to
7dcc72a
Compare
stevekinney
approved these changes
Jul 20, 2021
server/logger.js
Outdated
| @@ -0,0 +1,20 @@ | |||
| class Logger { | |||
There was a problem hiding this comment.
I might simplify it like this:
const timeStamp = () => '[' + new Date().toISOString() + ']';
const logger = {
log: console.log.bind(null, timeStamp()),
warn: console.warn.bind(null, timeStamp()),
error: console.error.bind(null, timeStamp()),
debug: console.debug.bind(null, timeStamp()),
}
module.exports = logger;But, I don't think it really matters too much.
Contributor
Author
There was a problem hiding this comment.
+, implemented with .call though so timestamp value updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adds timestamps to console
log,warnanderrorLogs and error sample:
Why?
Helps investigating logs
Checklist
Closes
How was this tested: