allow selection in code block #2987
Open
+5
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
When code block is maximized, if the user tries to select the code to copy, the component suddenly minimizes. This PR allows the user to select text without triggering minimizing.
Screenshots (if applicable) 📸
Design Considerations 🎨
To get selecting working, this PR makes the CodeMirror editor always "editable" which really means focusable and selectable. Readonly still controls if the user can change the code by typing. This setup gives a pretty reasonable UX, where the user can selected text from the editor by mouse or keyboard, and scroll with up/down arrows. It's a little more "edity" than we'd probably want, but we get a lot for free. Since the editor now receives the focus, we can remove the tab index on its parent div.
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?