Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jhauschild
Copy link
Member

@jhauschild jhauschild commented Oct 20, 2022

Creating a pull request in an effort to finally merge this.

What's actually missing for this?

  • add a dipole-conserving example model using the shift symmetry
  • Write a small test to ensure everything works with non-trivial shift symmetry
  • Document the shift symmetry in the user guide

@Jakob-Unfried Jakob-Unfried added this to the Release 1.0 milestone Apr 25, 2023
@Jakob-Unfried

This comment was marked as outdated.

@jhauschild
Copy link
Member Author

Just saying, it's probably a good idea to resolve the merge conflicts and merge the current main branch first, since #267 moved around measurmeent functions in mps.py as well, which this PR partially had to update as well. Let me know if you need help with that.

@Jakob-Unfried
Copy link
Member

Jakob-Unfried commented Aug 23, 2023

The merge introduced an error with purification MPS.
I have to stop working on this for now, so i pushed the mostly-complete merge

Fixed.

@Jakob-Unfried
Copy link
Member

@phzechm Do you have code for dipole conserving (or other) models using the shift symmetry?

@Jakob-Unfried Jakob-Unfried mentioned this pull request Oct 24, 2025
8 tasks
@Jakob-Unfried
Copy link
Member

Jakob-Unfried commented Oct 28, 2025

Only thing missing now is to adjust the new MPO environment building from #507 .

I am happy with doing only the bare minimum to get iDMRG running again and deferring edge cases / clean up to #560.
We should merge this ASAP, so we can get started with v2.

I dont understand the details of the new MPO environment builder, and hopefully we can fix this without me having to understand the details.
I have asked @anton-romen for help...

@Jakob-Unfried Jakob-Unfried mentioned this pull request Oct 30, 2025
@Jakob-Unfried Jakob-Unfried merged commit 818b8a5 into main Oct 30, 2025
12 checks passed
@Jakob-Unfried Jakob-Unfried deleted the shift-symmetry branch October 30, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants