fix: v0 bashrc file #1307
Merged
fix: v0 bashrc file #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
|
PTAL @VoVAllen The merge operation overrides |
Signed-off-by: Keming <[email protected]>
|
|
Is the problem fixed in this pr or not? |
Fixed by putting the "conda activate envd" into the last step of Python. BTW, "conda init bash" will still be written to root bashrc. That may need more refactoring. But I prefer to keep it as it is in v0. V1 doesn't have this issue. |
frostming
pushed a commit
to frostming/envd
that referenced
this pull request
Dec 16, 2022
* fix: v0 bashrc file Signed-off-by: Keming <[email protected]> * reorder py llb Signed-off-by: Keming <[email protected]> * fix go emb Signed-off-by: Keming <[email protected]> Signed-off-by: Keming <[email protected]> Signed-off-by: Frost Ming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keming [email protected]