refact: bump tablewriter to v1, fix the breaking change #2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the olekukonko/tablewriter dependency to v1 and replaces all direct tablewriter calls with a shared CreateTable factory to adapt to the new builder API.
- Introduces
CreateTableinformatter/tableand switches existing renderers to use it - Removes repetitive table setup in various formatters (
image_prune.go,image.go,env.go,context.go) - Bumps
tablewriter(and several other modules) ingo.mod
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/app/image_prune.go | Switched from tablewriter.NewWriter to formatter/table.CreateTable |
| pkg/app/formatter/table/image.go | Replaced inline tablewriter setup with CreateTable and Header |
| pkg/app/formatter/table/env.go | Consolidated all table config into new CreateTable implementation |
| pkg/app/formatter/table/context.go | Updated to use CreateTable instead of inline setup |
| go.mod | Bumped olekukonko/tablewriter to v1.0.7 (and other indirect deps) |
Comments suppressed due to low confidence (2)
pkg/app/formatter/table/env.go:91
- Consider adding unit tests for
CreateTableto ensure headers, row wrapping, and alignment behave as expected under the new v1 API, preventing regressions in table formatting.
func CreateTable(w io.Writer) *tablewriter.Table {
pkg/app/formatter/table/env.go:98
- [nitpick] The new
CreateTabledisables borders for all tables (usingtw.BorderNone), whereas the originalcreateTableenabled borders for dependency and port-binding tables. If you rely on borders for clarity in those tables, consider exposing a border option or restoring the previous border setting for those cases.
Borders: tw.BorderNone,
Signed-off-by: Keming <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the tablewriter dependency to v1 and updates the Docker error handling logic to fix breaking changes in the API. Key changes include replacing client.IsErrNotFound with errdefs.IsNotFound, refactoring table rendering functions to return errors, and updating dependency versions in go.mod.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/envd/docker.go | Updated error checks to use errdefs.IsNotFound |
| pkg/driver/docker/docker.go | Replaced client.IsErrNotFound with errdefs.IsNotFound in multiple methods |
| pkg/app/image_prune_test.go | Modified test to capture error returned by renderPruneReport |
| pkg/app/image_prune.go | Refactored renderPruneReport to return an error and use CreateTable |
| pkg/app/image_describe.go | Updated table rendering to return errors for dependencies |
| pkg/app/image.go | Updated table rendering to return errors instead of silently rendering |
| pkg/app/formatter/table/image.go | Refactored RenderImages with error handling on table.Append and table.Render |
| pkg/app/formatter/table/env.go | Updated environment table rendering functions to return errors |
| pkg/app/formatter/table/context.go | Modified RenderContext to return error on failure during table.Append |
| pkg/app/env_ls.go | Updated call to RenderEnvironments to return its error |
| pkg/app/env_describe.go | Updated error handling in rendering dependencies and port bindings |
| pkg/app/context_ls.go | Modified table rendering call for RenderContext to handle errors |
| go.mod | Bumped multiple dependency versions including tablewriter and Docker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.