feat: use psycopg pool to avoid conflicts in concurrent request #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the database client to use psycopg_pool.AsyncConnectionPool for managing connections and avoids conflicts in concurrent requests. It replaces the old transaction/cursor patterns with a unified get_connection context manager and updates the pipeline and registry to use it. Tests are updated to insert and query data concurrently, and a concurrency test for the HTTP service is added.
- Introduced
select_transaction_buffer_connandlimit_to_transaction_buffer_connto scope queries to the current transaction. - Replaced the single-connection model in
VechordClientwith a connection pool and newget_connectioncontext manager. - Updated pipeline and registry modules to use pooled connections and adjusted tests for concurrent behavior.
- Added
psycopg-pooldependency inpyproject.toml.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vechord/client.py | Switched to AsyncConnectionPool, added get_connection and removed old cursor management. |
| vechord/registry.py | Updated select calls to use select_transaction_buffer_conn. |
| vechord/pipeline.py | Replaced transaction contexts with get_connection and buffer limiters. |
| tests/test_table.py | Adjusted test to insert chunks concurrently and renamed test. |
| tests/test_service.py | Added a concurrent DB transaction test for the HTTP service. |
| pyproject.toml | Added psycopg-pool dependency. |
Comments suppressed due to low confidence (2)
vechord/client.py:29
- [nitpick] Consider renaming
limit_to_transaction_buffer_connto a shorter, more descriptive name (e.g.,limit_to_tx_buffer) to improve readability and maintainability.
async def limit_to_transaction_buffer_conn(conn: AsyncConnection):
vechord/client.py:55
- Add a docstring for
get_connectionexplaining its behavior, including when it reuses an existing transaction-scoped connection versus retrieving one from the pool.
async def get_connection(self):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @xieydd