fix: split text-emb & multimodal-emb #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR separates the generic embedding step into two distinct kinds—text-emb and multimodal-emb—and updates the pipeline logic to fetch and use them independently.
- Split the
PROVIDER_MAP["embedding"]entry intotext-embandmultimodal-emb - Updated
run_dynamic_pipelineto retrieve and handle both text and multimodal embeddings - Adjusted vectorization and dimension logic based on which embedding is present
Comments suppressed due to low confidence (3)
vechord/pipeline.py:98
- Rename the variable
embtotext_emb(and similarly update its usages) to clearly distinguish it from themultimodalvariable.
emb: Optional[BaseEmbedding] = calls.get("text-emb")
vechord/pipeline.py:64
- Update any README or docs that reference the old
embeddingstep to now mentiontext-embandmultimodal-embso users know about the new provider kinds.
"text-emb": {
vechord/pipeline.py:100
- [nitpick] Consider explicitly handling the case where both a text and a multimodal embedding are provided, or document which one takes precedence to avoid silent conflicts.
if not (emb or multimodal):
xieydd
requested changes
Jul 5, 2025
Member
xieydd
left a comment
There was a problem hiding this comment.
"POST /api/run HTTP/1.1" 422 Unprocessable Entity
INFO failed to decode the request '/api/run' body <class service.py:55
'vechord.model.web.RunRequest'>: Invalid enum value
'multimodal-emb' - at `$.steps[1].kind`
Pydantic validate error.
Signed-off-by: Keming <[email protected]>
Member
Author
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.