refact: use msgspec struct to simplify gemini req/resp construction #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how Gemini requests and responses are constructed by adopting msgspec structs and streamlines registry return-type handling, while also introducing InputType support for different data formats.
- Added
get_iterator_typeto unwrap nested iterable return types inVechordRegistry - Replaced ad-hoc JSON dicts with
msgspec.json.Encoder/Decodercalls across extract, evaluate, entity, chunk, and augment modules - Introduced
InputTypeenum and updatedrun_dynamic_pipelineto handle TEXT, PDF, and IMAGE inputs
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vechord/registry.py | Added iterator-type unwrapping helper for registry decorator |
| vechord/pipeline.py | Introduced InputType and improved OCR branching logic |
| vechord/model/web.py | Added InputType enum and changed RunAck.uid to UUID |
| vechord/model/gemini.py | New msgspec-based Gemini API structs and helpers |
| vechord/extract.py | Refactored GeminiExtractor to use generic query method |
| vechord/log.py | Lowered default log level from DEBUG to INFO |
Comments suppressed due to low confidence (2)
vechord/pipeline.py:140
- The new error branch for missing OCR providers on PDF/IMAGE inputs isn't covered by tests. Add tests to verify that a ValueError is raised when
input_typeis PDF or IMAGE but no OCR step is provided.
raise ValueError(
vechord/model/web.py:40
- [nitpick] Changing
uidfromstrtoUUIDalters the API contract. Consider updating docstrings or migration notes so consumers know to handle aUUIDobject.
uid: UUID
Signed-off-by: Keming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.