refact: reduce the complexity of voyage client #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Voyage client by extracting common logic into a new provider class and centralizing request/response handling.
- Adds
VoyageEmbeddingProviderto handle HTTP calls and rate limiting - Introduces factory methods (
from_text,build) and aget_embhelper in thevoyagemodels - Updates embedding classes to use the new provider and model APIs
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vechord/provider.py | Added VoyageEmbeddingProvider for embedding HTTP calls |
| vechord/model/voyage.py | Defined VoyageEmbeddingRequest/Response, helpers, and factories |
| vechord/model/jina.py | Updated JinaEmbeddingRequest.from_text signature to accept model |
| vechord/embedding.py | Refactored embedding classes to use VoyageEmbeddingProvider and new model APIs |
Comments suppressed due to low confidence (4)
vechord/model/voyage.py:26
- Consider adding unit tests for
get_emb, covering both list-based embeddings and buffer-based embeddings, and the error path whendatais empty.
def get_emb(self) -> np.ndarray:
vechord/model/voyage.py:49
- Add tests for
VoyageEmbeddingRequest.from_textto verify that the factory sets all fields correctly, includinginput_type,model, andoutput_dimension.
def from_text(
vechord/model/voyage.py:84
- Add tests for
VoyageMultiModalEmbeddingRequest.buildto ensure it correctly constructsinputsfor text, image, and URL combinations.
def build(
vechord/provider.py:162
- The
querymethod onVoyageEmbeddingProvideris typed to acceptGeminiEmbeddingRequestbut should useVoyageEmbeddingRequest. Please update the parameter type and importVoyageEmbeddingRequestaccordingly.
async def query(self, req: GeminiEmbeddingRequest) -> VoyageEmbeddingResponse:
Signed-off-by: Keming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.