fix: pad the defaults to match the length of fields #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not match the __struct_defaults__ length. Add tests. Suppress the UniqueViolation error when creating new tables or indexes. Signed-off-by: Keming <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in msgspec struct handling where the length of __struct_fields__ and __struct_defaults__ don't match, causing issues in the todict() method. Additionally, it suppresses UniqueViolation errors when creating database tables or indexes to handle concurrent creation scenarios.
- Pads the defaults tuple with
msgspec.NODEFAULTwhen defaults are shorter than fields - Changes zip operation to use
strict=Truefor safer iteration - Suppresses UniqueViolation errors in database table/index creation
- Updates error message to include "Graph" provider alongside OCR
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vechord/spec.py | Fixes struct defaults padding bug and adds kw_only parameter to DefaultChunk |
| vechord/client.py | Suppresses UniqueViolation errors in table and index creation |
| vechord/pipeline.py | Updates error message to mention Graph provider |
| tests/test_spec.py | Adds comprehensive tests for the struct defaults bug fix |
Comments suppressed due to low confidence (1)
tests/test_spec.py:115
- [nitpick] The class name 'ReDocument' is unclear and doesn't convey its purpose as a test class for demonstrating the struct defaults mismatch scenario. Consider a more descriptive name like 'TestDocumentWithExtraField' or 'DocumentWithMismatchedDefaults'.
class ReDocument(DefaultDocument):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug when the
__struct_fields__length does not match the__struct_defaults__length. Add tests.Suppress the UniqueViolation error when creating new tables or indexes.