feat: allow user prompt #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for user-customizable prompts across multiple components in the vechord library. The change allows users to override default prompts for extraction, evaluation, entity recognition, and chunking operations.
- Extracted hardcoded prompts into module-level constants for better maintainability
- Added optional
promptparameters to constructors allowing user customization - Updated docstrings for GraphEntity and GraphRelation classes to improve documentation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vechord/model/internal.py | Added docstrings to GraphEntity and GraphRelation classes |
| vechord/extract.py | Extracted prompts to constants and added user prompt parameter to GeminiExtractor |
| vechord/evaluate.py | Refactored UMBRELA evaluator to use configurable prompts with separate field template |
| vechord/entity.py | Extracted entity recognition prompts to constants and added prompt customization |
| vechord/chunk.py | Refactored chunking prompts to constants and added prompt parameter to GeminiChunker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.