fix: force llm to generate descriptions for entity and relation #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR forces the LLM to generate descriptions for entities and relations by making description fields required instead of optional with empty defaults. The changes also include improvements to multimodal embedding handling and code refactoring for better maintainability.
- Makes entity and relation description fields required to force LLM generation
- Improves multimodal embedding parameter handling and method signatures
- Refactors pipeline code for better chunk handling and graph processing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vechord/model/internal.py | Makes description fields required for GraphEntity and GraphRelation |
| vechord/graph.py | Updates image recognition prompt to generate better descriptions |
| vechord/embedding.py | Standardizes multimodal embedding method signatures with optional text parameter |
| vechord/model/voyage.py | Reorders parameters in VoyageMultiModalEmbeddingRequest.build method |
| vechord/pipeline.py | Refactors chunk handling, adds BaseReranker import, and improves embedding function selection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.