fix: dynamic pipeline namespace & keyword args #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes namespace updates via a new method and refines how keywords are instantiated in the dynamic pipeline.
- Introduces
reset_namespacein the registry to unify namespace assignment for both registry and client. - Updates
run_dynamic_pipelineto usereset_namespaceinstead of direct attribute mutation. - Changes
Keywordinstantiation to use a positional argument for brevity.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vechord/registry.py | Added reset_namespace method to set ns on registry and client |
| vechord/pipeline.py | Switched to reset_namespace call and adjusted Keyword usage |
Comments suppressed due to low confidence (4)
vechord/registry.py:81
- Missing docstring for public method
reset_namespace. Consider adding a clear docstring explaining its purpose and effects.
def reset_namespace(self, namespace: str):
vechord/pipeline.py:96
- The new
reset_namespacepath in the pipeline isn’t covered by existing tests. Consider adding a unit test to verify the namespace is correctly propagated.
vr.reset_namespace(request.name)
vechord/pipeline.py:135
- [nitpick] Using a positional argument for
Keywordreduces clarity. Consider using the explicit named parameter (Keyword(text=chunks[i])) to improve readability.
keyword=Keyword(chunks[i]) if use_keyword_index else None,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.