Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Dec 7, 2024

  1. Switch the default device from CPU to current global device automatically detected by paddle
  2. Allow lstsq fallback to CPU implementation when default device is not CPU, with propriate warning given, or the test_tensor_ring_als will fail when GPU is available.
  3. Relax Paddle version check to allow nightly build version which a lot of paddle users has been installed

test result:

TENSORLY_BACKEND='paddle' pytest -s -v -x tensorly

B70AAC32F9C348F366604742BF5525F9

@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (5a80db8) to head (fc144dc).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files         132      132           
  Lines        7851     7843    -8     
=======================================
- Hits         6907     6900    -7     
+ Misses        944      943    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yngvem yngvem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a tiny comment regarding the docstring change.

Remove 'r'
Copy link
Contributor

@yngvem yngvem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yngvem yngvem merged commit 89cae25 into tensorly:main Dec 7, 2024
10 checks passed
@HydrogenSulfate HydrogenSulfate deleted the HydrogenSulfate/fix_device branch December 8, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants