This repository was archived by the owner on May 29, 2024. It is now read-only.
Rename ZMQ plugin #157
Merged
Rename ZMQ plugin #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes a silent failure of Dynaconf to load the respective config settings.
Member
|
Maybe we can use this PR for renaming pyvast-threatbus -> vast-threatbus as well, if we're doing breaking changes anyways. |
Member
I'll do that in a separate PR so we have an easier time adapting downstream. |
lava
approved these changes
Aug 9, 2021
Member
lava
left a comment
There was a problem hiding this comment.
The changes are just mechanical, and we already verified experimentally that we didn't miss anything.
Note to self: We need to publish the package under the new name to PyPi when merging this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The PR renames the ZeroMQ plugin from
zmq-apptozmq. For one, the dash caused bugs in combination with Dynaconf and configuration (zmq-appvszmq_app). Moreover, the suffix-appis a bit confusing because it's technically a plugin.📝 Checklist
🎯 Review Instructions
TBD