Addin optional session token to inputs #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using the action with iam role / tested this with IAM role in our environment and it worked correctly. Disclaimer: Not a developer so if something else needs to be done to get this working correctly let me know.
Contributor
|
thanks for the contribution. It looks like you didn't commit the full source? I only see it getting retrieved in utils.ts, but where is the session token used? |
Contributor
Author
|
So tbh that's all that was needed for this to work. With my limited node knowledge I assumed all that's needed is to update this function Line 15 in 7772cfd and then it gets used automatically below : Lines 76 to 77 in 7772cfd Lines 102 to 103 in 7772cfd Since the session token is part of the credentials and is returned from assume-role in aws / needs to be passed together with access-key / secret-key. |
Contributor
|
you're right, my mistake. running pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the action with iam role / tested this with IAM role
in our environment and it worked.
Disclaimer: Not a developer so if something else needs to be done to get
this working correctly let me know.
Changes