Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Apr 7, 2016

@HipsterBrown review?

Signed-off-by: Rick Waldron [email protected]

@HipsterBrown
Copy link
Contributor

Awesome update! 👍 LGTM

${assets.join('\n')}
If you need to deploy them to your Tessel 2, you must create a .tesselinclude
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "create" a .tesselinclude or something else to reflect that they probably have one due to t2 init?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the project wasn't started with t2 init, they will have to create the file. We could also say "type t2 init", but what if they did and purposely deleted the .tesselinclude file, thinking that they didn't need to use it? It might seem strange to say "run t2 init" to someone that already did that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds fine to leave as is

@Frijol
Copy link
Member

Frijol commented Apr 8, 2016

Made a PR to the start page to reflect the changes: tessel/t2-start#88

file that lists the file and directory assets for your application. This can be
created manually or by typing 't2 init'.
For more information, visit: https://tessel.io/docs/cli#starting-projects
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Frijol thanks for review—I think this is much better, but let me know!

@Frijol
Copy link
Member

Frijol commented Apr 8, 2016

looks good to me!

@rwaldron
Copy link
Contributor Author

rwaldron commented Apr 8, 2016

@Frijol thanks for the review and follow up!

@rwaldron rwaldron merged commit 4b3f72f into tessel:master Apr 8, 2016
tikurahul pushed a commit to tikurahul/t2-cli that referenced this pull request Apr 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants