-
Notifications
You must be signed in to change notification settings - Fork 56
Implement complete tesselinclude detect spec. Closes gh-638 #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Awesome update! 👍 LGTM |
lib/tessel/deploy.js
Outdated
| ${assets.join('\n')} | ||
| If you need to deploy them to your Tessel 2, you must create a .tesselinclude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be "create" a .tesselinclude or something else to reflect that they probably have one due to t2 init?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the project wasn't started with t2 init, they will have to create the file. We could also say "type t2 init", but what if they did and purposely deleted the .tesselinclude file, thinking that they didn't need to use it? It might seem strange to say "run t2 init" to someone that already did that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds fine to leave as is
|
Made a PR to the start page to reflect the changes: tessel/t2-start#88 |
Signed-off-by: Rick Waldron <[email protected]>
| file that lists the file and directory assets for your application. This can be | ||
| created manually or by typing 't2 init'. | ||
| For more information, visit: https://tessel.io/docs/cli#starting-projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Frijol thanks for review—I think this is much better, but let me know!
|
looks good to me! |
|
@Frijol thanks for the review and follow up! |
…ssel#639) Signed-off-by: Rick Waldron <[email protected]>
@HipsterBrown review?
Signed-off-by: Rick Waldron [email protected]