Add Node version output to t2 version command
#679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/tessel/version.js
Outdated
| */ | ||
| Tessel.prototype.fetchCurrentNodeVersion = function() { | ||
| return this.simpleExec(['node', '--version']) | ||
| .then(function versionRead(version) { |
There was a problem hiding this comment.
Use arrow functions when you can.
There was a problem hiding this comment.
Okay. I was following what I saw, and it was a lot of mixed between function keyword and arrow functions.
There was a problem hiding this comment.
I know.. 😄. Going forward we want to avoid adding more, and cleaning up as we go.
|
Updated based on @rwaldron feedback and rebased onto latest master. |
| }) | ||
| .catch(() => { | ||
| logs.info(output('Firmware', firmwareVersion)); | ||
| logs.info(output('Node', 'unknown')); |
|
Great work!! |
|
Thanks! More to come. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667
This adds additional information to the
t2 versioncommand. If for some reason it fails to fetch the Node version, but was able to get the firmware version, it will output just that along with unknown for the Node version.If it fails to get the firmware version first then it skips trying to get the Node version and just outputs unknown for both versions.
All the tests pass. There weren't any currently testing
controller.tesselFirmwareVerionfunction, so I added those with this as well since I touched that function. I would love some feedback on the tests as I am pretty green with Sinon. :)Also, note that
Verionabove should beVersion, but I opted to not correct the spelling and would tackle that in a separate PR. Trying not to do so much here, but if you would like, I could rename that in this PR as well.