Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix setup.cfg not to install any examples#83

Merged
igordejanovic merged 1 commit intotextX:masterfrom
mgorny:examples
Nov 1, 2020
Merged

Fix setup.cfg not to install any examples#83
igordejanovic merged 1 commit intotextX:masterfrom
mgorny:examples

Conversation

@mgorny
Copy link
Contributor

@mgorny mgorny commented Nov 1, 2020

setup.cfg matches package names exactly, so the additional 'examples.*'
wildcard needs to be specified to prevent example sub-packages
from being installed.

Code review checklist

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
    to update for typo fixes and such).

setup.cfg matches package names exactly, so the additional 'examples.*'
wildcard needs to be specified to prevent example sub-packages
from being installed.
@igordejanovic
Copy link
Member

@mgorny Thanks. Even with this change I still get examples/{calc,csv} packaged in the resulting wheel. Do you have any clue why is that?

@mgorny
Copy link
Contributor Author

mgorny commented Nov 1, 2020

Did you clean/remove the build directory? Python installs everything cached there.

@igordejanovic
Copy link
Member

Ah, yes that was it, thanks. Will issue fix release shortly.

@igordejanovic igordejanovic merged commit 6cc377e into textX:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants