-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Runtime condenser supports rustg continuing line syntax #55339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime condenser supports rustg continuing line syntax #55339
Conversation
also made it skip empty lines because they sometimes randomly get printed in the middle of runtime messages
Cyberboss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHY IS THERE CPP IN THIS REPO THAT I'M JUST NOW LEARNING OF.
CAN 2020 GET ANY WORSE?
SpaceManiac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a pressing need to keep the .exe in the tree? I'd rather delete the binary than continue to bloat the Git repository. Could add a build script or something if that would help in return
|
That would, and could, be solved by removing it from this repo and moving it over to its own repo where we can use the release tab to handle the binaries. This is the tools folder, not the tools-src folder, it should have binaries for tools that need binaries to run. |
|
I'm thinking in the terms of a dev who wants to use this tool to handle a 1gb runtime file on their latest change that had like 50 different looping runtimes, so they can actually open it and see the runtime errors. There needs to be a binary published somewhere for that. (As that exact situation is how i even found out about the tool in the first place.) |
|
Repost of what I wrote in Discord:
I think I can find a way to accomplish all of:
|
|
The only way to achieve that that makes sense is to move runtime condenser to it own repo and use the release tab for binaries. Building a CD/CI pipeline for a program that averages 0.5 changes a year makes no sense when releases can be manually managed via the github tab. |
|
I suppose arguing (separate repo's Releases or CI/CD) vs. (this repo's Releases or CI/CD) is mostly a matter of preference at this point - either one would solve my grievance which is with compile outputs committed to Git. But we do have 4 tools that probably don't deserve to become four entire repos:
|
also made it skip empty lines because they sometimes randomly get printed in the middle of runtime messages