Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reduces species feature boilerplate #93570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reduces species feature boilerplate #93570

wants to merge 3 commits into from
+183 −372

Conversation

MrMelbert
Copy link
Member

About The Pull Request

Rather than having 100 separate list variables on SSaccessories, have 1 list for all feature keys that are associated with sprite accessories

This way you can get a feature by doing SSaccessories.feature_list[key], instead of necessitating SSaccessories.ears_list, SSaccessories.tail_list, etc.

This lets us cut back on a lot of boilerplate in prefs, dna, and organs

Why It's Good For The Game

We can see the benefit in this example: This is all the code for horn DNA, bodypart overlay, and preference

/datum/dna_block/feature/accessory/horn
	feature_key = FEATURE_HORNS
/datum/bodypart_overlay/mutant/horns
	layers = EXTERNAL_ADJACENT
	feature_key = FEATURE_HORNS
	dyable = TRUE

/datum/bodypart_overlay/mutant/horns/can_draw_on_bodypart(obj/item/bodypart/bodypart_owner)
	return !(bodypart_owner.owner?.obscured_slots & HIDEHAIR)
/datum/preference/choiced/species_feature/lizard_horns
	savefile_key = "feature_lizard_horns"
	savefile_identifier = PREFERENCE_CHARACTER
	category = PREFERENCE_CATEGORY_FEATURES
	main_feature_name = "Horns"
	should_generate_icons = TRUE
	relevant_organ = /obj/item/organ/horns

/datum/preference/choiced/species_feature/lizard_horns/icon_for(value)
	return generate_lizard_side_shot(get_accessory_for_value(value), "horns")

Changelog

🆑 Melbert
refactor: Refactored species unique organs slightly, particularly how they are set up at game start. Report any oddities, like invisible tails or wings
/:cl:

@github-actions github-actions bot added the Refactor Makes the code harder to read label Oct 22, 2025
@github-actions github-actions bot requested a review from Time-Green October 22, 2025 00:29
@Tsar-Salat
Copy link

Hell yeah.

From a downstream codebase that just recently made the bp overlay and accessories subsystem jump, this is very nice 👍

@MrMelbert
Copy link
Member Author

Next step says we can prolly auto-generate dna blocks for mutant bodypart overlays

image

Time-Green
Time-Green approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@Time-Green Time-Green left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's beautiful. Experience tells me this will need a TM
Actually you have webpanel access, can you just throw it on a server for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Time-Green Time-Green Time-Green approved these changes

@ExcessiveUseOfCobblestone ExcessiveUseOfCobblestone Awaiting requested review from ExcessiveUseOfCobblestone ExcessiveUseOfCobblestone is a code owner

@Ryll-Ryll Ryll-Ryll Awaiting requested review from Ryll-Ryll Ryll-Ryll is a code owner

@Mothblocks Mothblocks Awaiting requested review from Mothblocks Mothblocks is a code owner

@Fikou Fikou Awaiting requested review from Fikou Fikou is a code owner

Assignees

No one assigned

Labels

Refactor Makes the code harder to read

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrMelbert @Tsar-Salat @Time-Green