-
Notifications
You must be signed in to change notification settings - Fork 5k
Makes soda cans explode when exposed at low pressure. #93571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: MrMelbert <[email protected]>
"My vintage collection of Monkey Energy cans! No!!" |
Needs to check if the can is open |
how big of a boom? is it one that could damage someone, or is this just a little pop animation or smth (hurling cans at the voidwalker as fast as I can as we speak) |
Drink Space Cola! (Warning, do not drink in space.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOLY SHIT
/obj/item/reagent_containers/cup/soda_cans/Initialize(mapload, vol) | ||
. = ..() | ||
AddElement(/datum/element/slapcrafting, string_list(list(/datum/crafting_recipe/improv_explosive))) | ||
AddElement(/datum/element/atmos_sensitive, mapload) //Enables soda cans to explode in vaccuum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IT'S HAPPENING
/obj/item/reagent_containers/cup/soda_cans/should_atmos_process(datum/gas_mixture/air, exposed_temperature) | ||
return air.return_pressure() <= SODA_EXPLOSION_PRESSURE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YESSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS IT ONLY TOOK 6 YEARS
/obj/item/reagent_containers/cup/soda_cans/atmos_expose(datum/gas_mixture/air, exposed_temperature) | ||
if(reagents.total_volume) | ||
burst_soda(loc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to doompost about how technically just hooking into turf expose is better here because it's one and done (sensitive exists so stuff that wants to process on a loop while some atmos condition is met can), but with how you have it coded it is NOT (it maybe should be tho idk the cap's already off the thing right surely we should be checking for that)
That is so great. |
Funny to have selectively realistic behaviors like this on particular objects |
special interaction with beer kegs? |
Ideally we hit a wider pass of obvious pressure sensitive items, like balloons, inflatables, etc too, but this at least hits a proof of concept. |
why is this a qol? |
About The Pull Request
Fun idea discussed on the discord.
At low pressure, cans of soda will burst at 67.458 kPa, which is WAY higher than I would have expected, but that may just say something about the construction of the average can of soda.
Why It's Good For The Game
Fun little realism feature, which I found amusing enough for a quick 15 minute project. Only applies to cans that are actually exposed to atmos, so a held can while in space or in the bag won't trigger this reaction.
Changelog
🆑
qol: Leaving a can of soda exposed to the elements at low pressure will now burst.
/:cl: