Ruby 3.0 keyword arguments compatibility (pass two) #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for all component types.
(shared between the streaming runner and the legacy runner)
This solution works without asking the end-user to use the "ruby2_keywords" gem.
|
Tested fine on a reasonably complex ETL setup. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Kiba ETL keyword arguments support for Ruby 2.7+ (and replaces #86 which is a previous attempt I wasn't completely happy with). See #85 for initial issue.
This works equally with Ruby
2.7.1and current Rubymaster(2.8.0-devinrbenv, withruby -vgiving3.0.0dev).Decision
Special thanks to @eregon and @mame for their valuable input during the past few months.
I have decided for now to use
ruby2_keywordslike Rails does, which means:ruby2_keywordsgemRelevant literature