Change markup for the Editor Field #855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has the entire WYSIWYG editor wrapped inside a
label.This is causing some problems because since the label has no
forattribute every time a user clicks anywhere in the field the click automatically triggers the media uploader modal since the media button is the first actionable input inside the filed.So we can either add a for attribute or, as I've done in the pull, wrap only the span with the title inside the label.