-
Notifications
You must be signed in to change notification settings - Fork 22
Test and stability fixes #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out. Instead of relying on splitting the widgets path, we instead just set the parent to the previous layout that we captured when entering the context. This fixes some issues when Maya will insert a '||' into the path, specifically when dealing with popup menus, and docked controls. Also added an as_parent method to Nested instances, this allows you to reuse the object as a parent for more controls.
…uence, which gives it most of the standard methods found on list. I also went ahead and added a reverse method, which for some reason is not on the MutableSequence abstract class. This made it a lot easier to teach others how to work with the collections, as they could just reuse what they knew about manipulating lists. The original API was left in place, and all tests continue to pass. Also extended the API of BoundCollection by inheriting from Sequence, which makes it more tuple-like.
…llback instead of an attribute. Had to special case it in the helpers/tools.py module so that regenerating the controls won't reintroduce the bug.
… of None. This fixes an issue when trying to bind the property when empty.
Forgot to include this last night. Added a test for the new reverse method, and updated the sort test to have unsorted content at the start, and actually call the primary sort method before calling with the reverse flag.
Instead of special special casing 'alwaysInvokeEnterCommandOnReturn', this adds an explicit callback_exceptions set. Which means when Autodesk adds another conflicting name we can just extend the set.
Extends the API of ObservableCollection by inheriting from MutableSequence
Changed how the exiting context manager determines the new parent layout
… broken by new inheritance chain
Noticed that forms had an an __all__ attribute but lists and gui did not. gui's is using the __lookup.values() as it's reference, seemed much simpler than copy and pasting all the strings.
Adding __all__ to lists.py and gui.py
Updated to use the new keyless syntax.
Updated to use the new keyless syntax. Moved the bindings operations to separate lines, mostly to make them a bit more visible.
Updated to use the new keyless syntax. Moved the binding operations to separate lines, to make them a bit more visible.
Fixed some child count errors in a few of the examples. Swapped the loops that needed a counter over to using `enumerate()` Added a new global example that lets you trigger all the others.
Updated to use the new keyless syntax. Tweaked the imports so it doesn't flood the local namespace anymore, instead I'm relying on the various modules' `__all__` attributes. Cleaned up the imports so they're all at the top of the module.
Updated to use the new keyless syntax. Changed the filter to using a nested function instead of the eval / lambda combo, which was throwing silent errors before. Moved the binding operations to their own lines.
Updated slightly to use the keyless syntax. Some minor naming tweaks. Refactored the imports to not use `import *`
Updated to use new keyless syntax. Fixed some issues with the module parsing if a module used MAYAVERSION or LOCALE. Used python to get the MAYA_MODULES_PATH env instead of calling into mel, also tweaked some of the path handling to use python constants. Put a fallback on the module edit button, so if the os can't determine an editor for .mod files, it uses notepad on windows, and vi everywhere else, hopefully.
Remove keys
Example updates
…proxy doesn't work...?) which simplifies the public face
Avoids a case where the reference to the parent is lost while inside the context manager.
Moving the call to add_current, to after we set self._parent to None.
Merged
Owner
Author
|
I found a bug in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the long-standing tweaks from the #31 Remove Keys branch with the Modal dialog behavior fixes. Speak now or forever hold your peace!