Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Lat Long NaN issue fixed #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akashmahale wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Lat Long NaN issue fixed #29

akashmahale wants to merge 1 commit into from

Conversation

@akashmahale
Copy link

@akashmahale akashmahale commented Apr 30, 2022

image

@huntfx
Copy link

huntfx commented Mar 16, 2023

This solves the bug but introduces another one. It's cutting off every point below 0 latitude.

image

Seems to work with !isNaN(latitude) && !isNaN(longitude) instead.

@polarfoxDev polarfoxDev mentioned this pull request Jul 16, 2023
Open
falkorichter
falkorichter suggested changes Jul 17, 2023
View reviewed changes
index.js
if ( latitude > 180 ) latitude = latitude - (2 ** 32) * SCALAR_E7;
if ( longitude > 180 ) longitude = longitude - (2 ** 32) * SCALAR_E7;

if ( type === 'json' ) latlngs.push( [ latitude, longitude ] );
Copy link

@falkorichter falkorichter Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34 really fixes it

@falkorichter falkorichter mentioned this pull request Jul 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@falkorichter falkorichter falkorichter requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akashmahale @huntfx @falkorichter