Ruby 3.4 compatibility #394
Merged
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it fails because |
|
@ekohl, for simplicity I'd go with explicit dependencies with a comment to check if it gets fixed once we're dropping older Ruby's. |
The base64 dependency really should be in oauth, but this is a workaround until it is.
|
Looks like there's a difference in the hammer-cli/test/unit/abstract_test.rb Line 188 in a8e710f The line in question is here: hammer-cli/lib/hammer_cli/abstract.rb Line 117 in a8e710f I'll leave this until after Foreman 3.14 branching but feel free to pick it up if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a warning raised on Ruby 3.3:
It also raises one about syslog:
However, this one is pulled in via logging and we don't care about syslog. TwP/logging#247 says this is a Ruby bug so we may need to accept it.