Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Nov 19, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? đź’– Please sponsor : )

SimaTian and others added 3 commits November 19, 2025 11:01
Update build check documentation

---------

Co-authored-by: Copilot <[email protected]>
Fixes #12660

### Context
The following assert fails:
`/mt /m` sometimes crashes with error:
```
Microsoft.Build.Framework.InternalErrorException: MSB0001: Internal MSBuild Error: Why are we trying to disconnect from a context that we already disconnected from?  Did we call DisconnectFromHost twice?
   at Microsoft.Build.Shared.ErrorUtilities.ThrowInternalError(String message, Exception innerException, Object[] args) in C:\Users\alinama\work\msbuild\src\Shared\ErrorUtilities.cs:line 69
   at Microsoft.Build.Shared.ErrorUtilities.VerifyThrow(Boolean condition, String unformattedMessage) in C:\Users\alinama\work\msbuild\src\Shared\ErrorUtilities.cs:line 195
   at Microsoft.Build.BackEnd.NodeProviderOutOfProcTaskHost.DisconnectFromHost(Int32 nodeId) in C:\Users\alinama\work\msbuild\src\Build\BackEnd\Components\Communications\NodeProviderOutOfProcTaskHost.cs:line 607
   at Microsoft.Build.BackEnd.TaskHostTask.Execute() in C:\Users\alinama\work\msbuild\src\Build\Instance\TaskFactories\TaskHostTask.cs:line 382
   at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() in C:\Users\alinama\work\msbuild\src\Build\BackEnd\TaskExecutionHost\TaskExecutionHost.cs:line 636
```

### Changes Made
Changed `_nodeIdToPacketFactory` and `_nodeIdToPacketHandler` from
`Dictionary` to `ConcurrentDictionary`.

### Testing
Manually tested to make sure the error is not there.

### Notes

---------

Co-authored-by: Jan ProvaznĂ­k <[email protected]>
@pull pull bot locked and limited conversation to collaborators Nov 19, 2025
@pull pull bot merged commit 6772529 into thompson-tomo:main Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants