Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Dec 9, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

ViktorHofer and others added 3 commits December 9, 2025 14:42
Stops PR like #12888 getting
opened

Add an empty global.json to eng/dependabot so that it never scans the
one in the repo root and then attempts to load and update the msbuild
sdks defined there.

Also rename Packages.props to Directory.Packages.props and delete the
unnecessary dependabot.csproj as dependabot now has native support for
D.P.props.

Unrelated but in the same files: Also remove `ProjectIsDeprecated`
conditions as that property is already dead.

---------

Co-authored-by: Copilot <[email protected]>
1. Fixes

2. 

3. ### Context
- In-proc node thread names omitted the node identifier, making thread
identification harder when multiple nodes run under the same host.

4. ### Changes Made
- Updated `NodeProviderInProc` to embed `nodeId` in the thread name when
spinning up an in-proc node thread:
- `nodeContext._inProcNodeThread.Name = $"In-proc Node {nodeId}
({_componentHost.Name})";`

Example:
```csharp
// Thread name now clearly identifies the node:
"In-proc Node 3 (BackEnd.MockHost)"
```

5. ### Testing
- Build succeeded: `./build.sh -v quiet`
- Bootstrapped environment and verified SDK: `source
artifacts/sdk-build-env.sh && dotnet --version`
- Sample build: `dotnet build src/Samples/Dependency/Dependency.csproj`
- Targeted tests (known existing failures remain unrelated): `dotnet
test src/Build.UnitTests/Microsoft.Build.Engine.UnitTests.csproj -m:1`

6. ### Notes
- Targeted test run reports pre-existing failures in BinaryLogger
roundtrip and ProjectGraph target list expectations; no changes made to
those areas in this PR.

> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `dnceng.pkgs.visualstudio.com`
> - Triggering command:
`/home/REDACTED/work/msbuild/msbuild/artifacts/bin/bootstrap/core/dotnet
dotnet build src/Samples/Dependency/Dependency.csproj` (dns block)
> - Triggering command:
`/home/REDACTED/work/msbuild/msbuild/artifacts/bin/bootstrap/core/dotnet
dotnet test src/Build.UnitTests/Microsoft.Build.Engine.UnitTests.csproj
-m:1` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/dotnet/msbuild/settings/copilot/coding_agent)
(admins only)
>
> </details>

<!-- START COPILOT CODING AGENT SUFFIX -->



<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> On NodeProviderInProc.cs:373-373, add {nodeId} to this name


</details>



<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: JanProvaznik <[email protected]>
@pull pull bot locked and limited conversation to collaborators Dec 9, 2025
@pull pull bot added the ⤵️ pull label Dec 9, 2025
@pull pull bot merged commit 3c42674 into thompson-tomo:main Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants