[pull] main from dotnet:main #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#12885) ### Context The XamlPreCompile targets in Microsoft.CSharp.CurrentVersion.targets and Microsoft.VisualBasic.CurrentVersion.targets were passing `GeneratedFilesOutputPath` to the Csc and Vbc tasks, which is unnecessary for XAML pre-compilation scenarios. ### Changes Made - Removed `GeneratedFilesOutputPath="$(CompilerGeneratedFilesOutputPath)"` parameter from the Csc task invocation in the XamlPreCompile target in Microsoft.CSharp.CurrentVersion.targets - Removed `GeneratedFilesOutputPath="$(CompilerGeneratedFilesOutputPath)"` parameter from the Vbc task invocation in the XamlPreCompile target in Microsoft.VisualBasic.CurrentVersion.targets - Updated comments in both files to document that XamlPreCompile intentionally omits this parameter while remaining otherwise identical to CoreCompile ### Testing - Full repository build succeeds - Sample projects build successfully with modified MSBuild ### Notes This intentionally diverges from the CoreCompile targets in Microsoft.CSharp.Core.targets and Microsoft.VisualBasic.Core.targets, which retain the GeneratedFilesOutputPath parameter. Both C# and VB implementations now have consistent changes. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: dsplaisted <[email protected]> Co-authored-by: rainersigwald <[email protected]>
### Context 9f56419 updated the InsertVSPayload task, and the parameter name for queuing build policies changed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )