infra: reduce javascript bundle size #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- enhanced tree shaking - update compress option
ec0fb87 to
be25df3
Compare
hermet
reviewed
Dec 24, 2024
| compress: { | ||
| pure_getters: true, | ||
| passes: 3, | ||
| drop_console: true, |
There was a problem hiding this comment.
Question: should we change only this value when we really want to debug the player with a logging?
There was a problem hiding this comment.
@hermet this config aims production build. When we want to debug, we can disable and check the log
hermet
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the JavaScript bundle, as well as the glue code, has been slightly reduced.
[Before]
[After]
lottie-player.jsbundle got-1%size reduction